etkr4k/bedolaga-cabinet
1
0
Fork 0
mirror of https://github.com/chillpadclub/bedolaga-cabinet.git synced 2026-07-29 18:13:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: stabilize useMemo deps and add category search to sidebar

Browse Source 
- Use activeSection instead of activeTreeInfo as useMemo dependency
  (activeTreeInfo is derived from activeSection, new object each render)
- Add category label matching to sidebar autocomplete search filter
  to match global search behavior
This commit is contained in:
Fringg
2026-03-29 02:56:54 +03:00
parent 21813ef82e
commit ea1c7359ce
2 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/components/admin/SettingsTreeSidebar.tsx
View File

@@ -56,6 +56,8 @@ export function SettingsTreeSidebar({
const translatedName = t(`admin.settings.settingNames.${formattedKey}`, formattedKey); const translatedName = t(`admin.settings.settingNames.${formattedKey}`, formattedKey);
if (translatedName.toLowerCase().includes(q)) return true; if (translatedName.toLowerCase().includes(q)) return true;
if (s.hint?.description?.toLowerCase().includes(q)) return true; if (s.hint?.description?.toLowerCase().includes(q)) return true;
const categoryLabel = t(`admin.settings.categories.${s.category.key}`, s.category.key);
if (categoryLabel.toLowerCase().includes(q)) return true;
return false; return false;
}) })
.slice(0, 8) .slice(0, 8)

6
src/pages/AdminSettings.tsx
View File

@@ -106,7 +106,8 @@ export default function AdminSettings() {
label: t(`admin.settings.categories.${key}`, key), label: t(`admin.settings.categories.${key}`, key),
settings, settings,
})); }));
}, [activeTreeInfo, allSettings, t]); // eslint-disable-next-line react-hooks/exhaustive-deps -- activeTreeInfo derived from activeSection
}, [activeSection, allSettings, t]);
// Filter settings for search - GLOBAL search across all settings // Filter settings for search - GLOBAL search across all settings
const filteredSettings = useMemo(() => { const filteredSettings = useMemo(() => {
@@ -168,7 +169,8 @@ export default function AdminSettings() {
if (activeTreeInfo) return t(`admin.settings.tree.${activeTreeInfo.child.id}`); if (activeTreeInfo) return t(`admin.settings.tree.${activeTreeInfo.child.id}`);
return t('admin.settings.title'); return t('admin.settings.title');
}, [activeSection, activeTreeInfo, t]); // eslint-disable-next-line react-hooks/exhaustive-deps -- activeTreeInfo derived from activeSection
}, [activeSection, t]);
// Render content based on active section // Render content based on active section
const renderContent = () => { const renderContent = () => {