etkr4k/bedolaga-cabinet
1
0
Fork 0
mirror of https://github.com/chillpadclub/bedolaga-cabinet.git synced 2026-07-29 18:13:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: add unmount safety guard to OIDC callback handler

Browse Source 
Prevent stale navigate('/') and setState calls after unmount
using mountedRef pattern.
This commit is contained in:
Fringg
2026-03-07 03:27:14 +03:00
parent b335d666c2
commit dfa7a09a7c
1 changed files with 12 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/components/TelegramLoginButton.tsx
View File

@@ -31,8 +31,17 @@ export default function TelegramLoginButton({ referralCode }: TelegramLoginButto
// OIDC callback handler (ref pattern to avoid stale closures and unnecessary re-inits) // OIDC callback handler (ref pattern to avoid stale closures and unnecessary re-inits)
const handleOIDCCallbackRef = const handleOIDCCallbackRef =
useRef<(data: { id_token?: string; error?: string }) => void>(undefined); useRef<(data: { id_token?: string; error?: string }) => void>(undefined);
const mountedRef = useRef(true);
useEffect(() => {
mountedRef.current = true;
return () => {
mountedRef.current = false;
};
}, []);
handleOIDCCallbackRef.current = async (data: { id_token?: string; error?: string }) => { handleOIDCCallbackRef.current = async (data: { id_token?: string; error?: string }) => {
if (!mountedRef.current) return;
if (data.error || !data.id_token) { if (data.error || !data.id_token) {
setOidcError(data.error || t('auth.loginFailed')); setOidcError(data.error || t('auth.loginFailed'));
setOidcLoading(false); setOidcLoading(false);
@@ -42,8 +51,9 @@ export default function TelegramLoginButton({ referralCode }: TelegramLoginButto
setOidcLoading(true); setOidcLoading(true);
setOidcError(''); setOidcError('');
await loginWithTelegramOIDC(data.id_token); await loginWithTelegramOIDC(data.id_token);
navigate('/'); if (mountedRef.current) navigate('/');
} catch (err: unknown) { } catch (err: unknown) {
if (!mountedRef.current) return;
let message = t('common.error'); let message = t('common.error');
if (err && typeof err === 'object' && 'response' in err) { if (err && typeof err === 'object' && 'response' in err) {
const resp = (err as { response?: { data?: { detail?: string } } }).response; const resp = (err as { response?: { data?: { detail?: string } } }).response;
@@ -51,7 +61,7 @@ export default function TelegramLoginButton({ referralCode }: TelegramLoginButto
} }
setOidcError(message); setOidcError(message);
} finally { } finally {
setOidcLoading(false); if (mountedRef.current) setOidcLoading(false);
} }
}; };